Convert the code in `src/core/colorspace.js to use ES6 classes #10007
Conversation
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/24ad212581b0ab4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/3b9c7505dd159de/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/24ad212581b0ab4/output.txt Total script time: 6.75 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/3b9c7505dd159de/output.txt Total script time: 24.95 mins
|
Reduces the amount of boilerplate code when defining the the sub-classes. Please note that a couple of the closures were kept, since it's not (yet) possible to include helper functions inside of `class`es.
Snuffleupagus
force-pushed
the
ColorSpace-class
branch
from
a1a84ad
to
a182907
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/05e53a6928a1ca9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/9b9a7ba8ea16ed4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/05e53a6928a1ca9/output.txt Total script time: 6.73 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/9b9a7ba8ea16ed4/output.txt Total script time: 24.54 mins
|
|
Thank you! Looks much easier this way. |
Reduces the amount of boilerplate code when defining the the sub-classes.
Please note that a couple of the closures were kept, since it's not (yet) possible to include helper functions inside of
classes.Replace all occurences of
varwithlet/constinsrc/core/colorspace.jsNote: For easier reviewing, I'd suggest looking at one commit at a time and also using the
?w=1URL flag to reduce the size of particularly the first diff.