Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid setting incorrect document URLs, in IE 11, when the browser history is updated (PR 10423 follow-up) #10461

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Avoid setting incorrect document URLs, in IE 11, when the browser history is updated (PR 10423 follow-up) #10461

merged 1 commit into from
Jan 16, 2019

Commits on Jan 16, 2019

  1. Avoid setting incorrect document URLs, in IE 11, when the browser his… 

    …tory is updated (PR 10423 follow-up)

Apparently in IE 11 when `history.{pushState, replaceState}` is called, there's actually a difference between not providing the *third* argument vs providing it set implicitly to `undefined`. It appears that in IE 11 it's actually being stringified, rather than ignored, which seems completely wrong (obviously other browsers aren't affected, so no surprises there).

This is yet another reason why I think the feature itself was a really bad idea, since it now requires extra/duplicated code just to prevent weird/incorrect URL behaviour in crappy browsers.
    @Snuffleupagus
    Snuffleupagus committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    ffe7981 View commit details
    Browse the repository at this point in the history