Do the final text scaling correctly in flushTextContentItem (issue 8276)
#10508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8276) It's necessary to take into account whether or not the text is vertical, to avoid either the textContent `width` or `height` becoming incorrect.
…nit-test This unit-test wasn't destroying the `loadingTask` when complete, as it should have done.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/882ce9dd476fc28/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c8bb1754454115d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c8bb1754454115d/output.txt Total script time: 17.75 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/882ce9dd476fc28/output.txt Total script time: 25.68 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/083868a9fb2babe/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/083868a9fb2babe/output.txt Total script time: 1.69 mins Published |
timvandermeij
approved these changes
Jan 29, 2019
|
Thank you for doing this! |
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's necessary to take into account whether or not the text is vertical, to avoid either the textContent
widthorheightbecoming incorrect.Fixes #8276; and subsumes PR #10456.
The other PR caused regressions (as I feared based on looking at its code), which suggests that it wasn't properly tested during development. Furthermore, the PR didn't include any kind of test which is necessary to prevent this from regressing yet again (since the existing tests didn't catch it previously).
Finally, after the PR was opened there hasn't been any response from the author, regarding either the test failures or the other comments, for two weeks which is why I've now chosen to submit this patch.