Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale stroking line width when using a tiling pattern. #10850

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

brendandahl
Copy link
Contributor

@brendandahl brendandahl commented May 23, 2019

Fixes #10566.

@brendandahl
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e5ad45c3de00976/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/3fd12efeb995681/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/e5ad45c3de00976/output.txt

Total script time: 17.82 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/3fd12efeb995681/output.txt

Total script time: 25.79 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@brendandahl brendandahl changed the title Scale stroking line width when using a tiling pattern. [WIP] Scale stroking line width when using a tiling pattern. May 24, 2019
@brendandahl
Copy link
Contributor Author

Don't merge yet...I see another potential issue that I can fix that I want to bundle with this.

@janpe2
Copy link
Contributor

janpe2 commented May 24, 2019

This fixes #10566, which is probably the issue you were looking for.

src/display/canvas.js Show resolved Hide resolved
src/display/canvas.js Outdated Show resolved Hide resolved
@timvandermeij
Copy link
Contributor

I think this is good to merge once the two comments above are resolved.

@brendandahl brendandahl changed the title [WIP] Scale stroking line width when using a tiling pattern. Scale stroking line width when using a tiling pattern. Jul 8, 2019
@brendandahl
Copy link
Contributor Author

I won't have time to do the full fix yet, so for now we can live with this workaround. I've filed #10955 for the full fix.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/68c920d3d334c8f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/68c920d3d334c8f/output.txt

Total script time: 1.70 mins

Published

@timvandermeij timvandermeij merged commit 87f36e3 into mozilla:master Jul 12, 2019
@timvandermeij
Copy link
Contributor

timvandermeij commented Jul 12, 2019

Thank you for improving this!

I won't have time to do the full fix yet, so for now we can live with this workaround. I've filed #10955 for the full fix.

Fixing this incrementally is perfectly fine because at least now it works and we have reference test coverage, making a future improvement easier to verify.

(I'll make new reference images in the other PR.)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table borders
4 participants