Ensure that the loading indicator, in the pageNumber input, is hidden when the viewer is closed #11033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
… when the viewer is closed Currently the indicator may remain visible even after the document has been closed, which seems weird given that no page is either visible nor rendering :-)
Snuffleupagus
force-pushed
the
viewer-close-updateLoadingIndicatorState
branch
from
c6150ee
to
cb1394c
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/73c2d2144be200e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/73c2d2144be200e/output.txt Total script time: 1.69 mins Published |
timvandermeij
approved these changes
Aug 1, 2019
|
Good find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the indicator may remain visible even after the document has been closed, which seems weird given that no page is either visible nor rendering :-)