Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextLayer] Only measure the width of the text, in _layoutText, for multi-char text divs #11097

Merged
merged 2 commits into from
Aug 25, 2019
Merged

[TextLayer] Only measure the width of the text, in _layoutText, for multi-char text divs #11097

merged 2 commits into from
Aug 25, 2019

Commits on Aug 25, 2019

  1. [TextLayer] Only measure the width of the text, in _layoutText, for… 

    … multi-char text divs

For performance reasons single-char text divs aren't being scaled, as outlined in a comment in `appendText`. Hence it doesn't seem necessary, or even a good idea, to unconditionally measuring the width of the text in `_layoutText`.
    @Snuffleupagus
    Snuffleupagus committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    b68f7bb View commit details
    Browse the repository at this point in the history

  2. [TextLayer] Simplify building of the *expanded* transform in `expandT… 

    …extDivs`

Rather than essentially re-computing the `originalTransform` every time, we can simply use it directly instead.
    @Snuffleupagus
    Snuffleupagus committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    a139804 View commit details
    Browse the repository at this point in the history