[Firefox] Remove unused addon l10n files (PR 9566 follow-up)
#11256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s during `gulp locale` (PR 9566 follow-up) With the removal of the (standalone) Firefox building code in PR 9566 (a year and a half ago), these files are now completely unused. Hence it doesn't really make sense to keep building them as part of `gulp locale`, and the existing files in the `l10n` folder can also be removed (thanks to version control, they're easy enough to restore should the need ever arise).
…portl10n` (PR 9566 follow-up) With the removal of the (standalone) Firefox building code in PR 9566 (a year and a half ago), these files are now completely unused in the GitHub repository[1]. Hence it doesn't really seem necessary to keep fetching them with `gulp importl10n`, and the existing files in the `l10n` folder can also be removed (thanks to version control, they're easy enough to restore should the need ever arise). The patch also allows an additional simplification, for the `gulp locale` and `gulp mozcentral` commands, since it's now possible to stop writing `l10n` files to the `extensions/firefox/` folder and instead just copy them similar to other build targets. --- [1] They're obviously still used in `mozilla-central`, for fallback messages displayed through `PdfStreamConverter.jsm`, but that doesn't make it necessary to keep them *here* as far as I'm concerned.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3aaf5c4ec2c062c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/3aaf5c4ec2c062c/output.txt Total script time: 1.62 mins Published |
timvandermeij
approved these changes
Oct 17, 2019
|
Looks like a good change to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Firefox] Stop building the
metadata.inc/chrome.manifest.incfiles duringgulp locale(PR 9566 follow-up)With the removal of the (standalone) Firefox building code in PR Remove the Firefox extension building code. #9566 (a year and a half ago), these files are now completely unused.
Hence it doesn't really make sense to keep building them as part of
gulp locale, and the existing files in thel10nfolder can also be removed (thanks to version control, they're easy enough to restore should the need ever arise).[Firefox] Stop fetching the
chrome.propertiesfiles duringgulp importl10n(PR 9566 follow-up)With the removal of the (standalone) Firefox building code in PR Remove the Firefox extension building code. #9566 (a year and a half ago), these files are now completely unused in the GitHub repository[1].
Hence it doesn't really seem necessary to keep fetching them with
gulp importl10n, and the existing files in thel10nfolder can also be removed (thanks to version control, they're easy enough to restore should the need ever arise).The patch also allows an additional simplification, for the
gulp localeandgulp mozcentralcommands, since it's now possible to stop writingl10nfiles to theextensions/firefox/folder and instead just copy them similar to other build targets.[1] They're obviously still used in
mozilla-central, for fallback messages displayed throughPdfStreamConverter.jsm, but that doesn't make it necessary to keep them here as far as I'm concerned.Update l10n files