Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the indices of arguments for RadialAxial. It is related to #10646. #11546

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

tamuratak
Copy link
Contributor

Fix the indices of arguments for the shading pattern of RadialAxial with SVG backend. It is related to #10646.

Load http://warp.da.ndl.go.jp/info:ndljp/pid/10205551/www.city.niigata.lg.jp/shisei/koho/kohoshi/shiho/backnumber/h25/shiho0217/pdf/0217_P1.pdf with SVG backend. Then we can see the following error in the console.

Uncaught (in promise) TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator)) (svg.js:1199)
    at SVGGraphics._makeShadingPattern (svg.js:1199)
    at SVGGraphics.shadingFill (svg.js:1073)
    at SVGGraphics.executeOpTree (svg.js:647)
    at SVGGraphics.group (svg.js:472)
    at SVGGraphics.executeOpTree (svg.js:728)
    at SVGGraphics.group (svg.js:472)
    at SVGGraphics.executeOpTree (svg.js:728)
    at eval (svg.js:540)

With this PR, the shading patterns are rendered well.

スクリーンショット 2020-01-29 19 31 24

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/0a0707cba692a8d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/0a0707cba692a8d/output.txt

Total script time: 1.76 mins

Published

@timvandermeij timvandermeij merged commit 517ccb7 into mozilla:master Jan 29, 2020
@timvandermeij
Copy link
Contributor

Nice find; thank you for the fix!

@tamuratak tamuratak deleted the radialaxial branch January 30, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants