Magnifier positioning in reftest analyzer #11686
Conversation
When reftest analyzer shows magnified pixels, there is a seemingly random offset between the mouse position and the magnified position. The reason for this is that reftest analyzer assumes all images have 800 * 1000 pixels but actually the test images have varying sizes.
That would be correct, as far as I can recall. /botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7349909c34f543d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/2d11df77d070bac/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/7349909c34f543d/output.txt Total script time: 19.89 mins
Image differences available at: http://54.67.70.0:8877/7349909c34f543d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/2d11df77d070bac/output.txt Total script time: 25.04 mins
Image differences available at: http://54.215.176.217:8877/2d11df77d070bac/reftest-analyzer.html#web=eq.log |
|
Nice improvement! |
When reftest analyzer shows magnified pixels, there is a seemingly random offset between the mouse position and the magnified position. The reason for this is that reftest analyzer assumes all images have 800 * 1000 pixels but actually the test images have varying sizes.
I copied the needed lines from
https://github.com/mozilla/gecko-dev/blob/master/layout/tools/reftest/reftest-analyzer.xhtml
(I assume that originally reftest analyzer has been copied from similar Mozilla repositories.)