[api-minor] Immediately release the font.data property once the font been attached to the DOM (PR 11777 follow-up)
#11844
Conversation
…t been attached to the DOM (PR 11777 follow-up) *This patch implements mozilla#11777 (comment) This extends the work from PR 11773 and 11777 further, by immediately releasing the `font.data` property once the font been attached to the DOM. By not unnecessarily holding onto this data on the main-thread, we'll thus reduce the memory usage of fonts even further (especially beneficial in longer documents with composite fonts). The new behaviour is controlled by the recently added `fontExtraProperties` API option (adding a new option just for this patch didn't seem necessary), since there's one edge-case in the SVG renderer where the `font.data` property is necessary (see the `pdf2svg` example). Note that while the default viewer does run clean-up with an idle timeout, that timeout will be reset whenever rendering occurs *or* when scrolling happens in the viewer. In practice this means that unless the user doesn't interact with the viewer in *any* way during an extended period of time, currently set to 30 seconds, the `PDFDocumentProxy.cleanup` method will never be called and font resources will thus not be cleaned-up.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/0e4636892428946/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c915efa096af8e5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/c915efa096af8e5/output.txt Total script time: 19.56 mins
Image differences available at: http://54.67.70.0:8877/c915efa096af8e5/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/0e4636892428946/output.txt Total script time: 24.98 mins
Image differences available at: http://54.215.176.217:8877/0e4636892428946/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3095bf6d75fa79b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/3095bf6d75fa79b/output.txt Total script time: 2.56 mins Published |
|
Looks like a good idea to me too. The sooner we can release unneeded resources, the better. Thanks! |
This patch implements #11777 (comment)
This extends the work from PR #11773 and #11777 further, by immediately releasing the
font.dataproperty once the font been attached to the DOM. By not unnecessarily holding onto this data on the main-thread, we'll thus reduce the memory usage of fonts even further (especially beneficial in longer documents with composite fonts).The new behaviour is controlled by the recently added
fontExtraPropertiesAPI option (adding a new option just for this patch didn't seem necessary), since there's one edge-case in the SVG renderer where thefont.dataproperty is necessary (see thepdf2svgexample).Note that while the default viewer does run clean-up with an idle timeout, that timeout will be reset whenever rendering occurs or when scrolling happens in the viewer. In practice this means that unless the user doesn't interact with the viewer in any way during an extended period of time, currently set to 30 seconds, the
PDFDocumentProxy.cleanupmethod will never be called and font resources will thus not be cleaned-up.