Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the (old) preprocessor from appending trailing whitespace when removing closing HTML comments #11992

Conversation

Snuffleupagus
Copy link
Collaborator

This can currently be seen in the built web/viewer.html file, at the line containing " <script src="viewer.js"></script> ".

…n removing closing HTML comments

This can currently be seen in the *built* `web/viewer.html` file, at the line containing "  <script src="viewer.js"></script>  ".
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1e520b1fb6a1dd2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/1e520b1fb6a1dd2/output.txt

Total script time: 3.43 mins

Published

@timvandermeij timvandermeij merged commit 63a7aaa into mozilla:master Jun 11, 2020
@timvandermeij
Copy link
Contributor

Looks good!

@Snuffleupagus Snuffleupagus deleted the preprocessor-rm-HTML-comment-trailing-whitespace branch June 12, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants