Also enable renderInteractiveForms by default in the viewer components (PR 12201 follow-up)
#12261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts (PR 12201 follow-up) Given that `renderInteractiveForms` is now enabled by default in "full" viewer, it seems reasonable to enable it by default in the viewer components as well. Especially considering that it's simple to disable, when creating the affected components, for anyone implementing their own viewer.
Snuffleupagus
force-pushed
the
renderInteractiveForms-defaults
branch
from
579d2af
to
a8de614
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/aebc6db74078a32/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/aebc6db74078a32/output.txt Total script time: 3.44 mins Published |
timvandermeij
approved these changes
Aug 22, 2020
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that
renderInteractiveFormsis now enabled by default in "full" viewer, it seems reasonable to enable it by default in the viewer components as well.Especially considering that it's simple to disable, when creating the affected components, for anyone implementing their own viewer.