Ensure that the empty dictionary won't be accidentally modified, and slightly improve the "SaveDocument" handler in src/core/worker.js
#12375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there's nothing that prevents modification of the `Dict.empty` primitive, which obviously needs to be *truly* empty to prevent any future (hard to find) bugs.
…core/worker.js` - Check that the "Info"-entry, in the XRef-trailer, is actually a dictionary before accessing it. This is similar to the `PDFDocument.documentInfo` method and follows the general principal of validating data carefully before accessing it, given how often PDF-software may create corrupt PDF files. - Slightly simplify the "XFA"-lookup, since there's no point in trying to fetch something from the empty dictionary.
Snuffleupagus
force-pushed
the
emptyDict-set
branch
from
3ba1ad0
to
ed4e7cd
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f9f417c06af9735/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6f68169877217d4/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/f9f417c06af9735/output.txt Total script time: 27.22 mins
Image differences available at: http://54.67.70.0:8877/f9f417c06af9735/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/6f68169877217d4/output.txt Total script time: 29.76 mins
Image differences available at: http://54.215.176.217:8877/6f68169877217d4/reftest-analyzer.html#web=eq.log |
timvandermeij
changed the title
src/core/worker.jssrc/core/worker.js
timvandermeij
approved these changes
Sep 15, 2020
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the empty dictionary won't be accidentally modified
Currently there's nothing that prevents modification of the
Dict.emptyprimitive, which obviously needs to be truly empty to prevent any future (hard to find) bugs.A couple of small improvements in the "SaveDocument" handler in
src/core/worker.jsCheck that the "Info"-entry, in the XRef-trailer, is actually a dictionary before accessing it. This is similar to the
PDFDocument.documentInfomethod and follows the general principal of validating data carefully before accessing it, given how often PDF-software may create corrupt PDF files.Slightly simplify the "XFA"-lookup, since there's no point in trying to fetch something from the empty dictionary.