[api-minor] Set font size and color for text widget annotations #12828
Conversation
|
If #12831 gets merged, i would rewrite my changes to use the defaultAppearance parser and font-size calculations for auto-size provided in that PR |
dhufnagel
force-pushed
the
feature/annotation_layer_display_fontsize
branch
from
8a11a30
to
013e935
Compare
dhufnagel
force-pushed
the
feature/annotation_layer_display_fontsize
branch
from
013e935
to
ee49880
Compare
|
I've rewritten my old commit and now use the parsed default appearance data which was introduced by @calixteman in #12831 . |
dhufnagel
force-pushed
the
feature/annotation_layer_display_fontsize
branch
from
ee49880
to
aefd111
Compare
|
Please also follow https://github.com/mozilla/pdf.js/wiki/Squashing-Commits |
dhufnagel
force-pushed
the
feature/annotation_layer_display_fontsize
branch
2 times, most recently
from
7c5bf99
to
6765bf9
Compare
|
Looks good to me once the merge conflict is resolved (happened because we just merged #12886 that also touched the same code, but simplified it). We'll run a preview and the tests after this is done. |
use the default appearance to set the font size and color of a text annotation widget
dhufnagel
force-pushed
the
feature/annotation_layer_display_fontsize
branch
from
6765bf9
to
c5083cd
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8c584538f995328/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8c584538f995328/output.txt Total script time: 4.23 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/948062b78ea4be7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/6b557d91a88d37c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/948062b78ea4be7/output.txt Total script time: 26.87 mins
Image differences available at: http://54.67.70.0:8877/948062b78ea4be7/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/6b557d91a88d37c/output.txt Total script time: 27.89 mins
Image differences available at: http://3.101.106.178:8877/6b557d91a88d37c/reftest-analyzer.html#web=eq.log |
timvandermeij
changed the title
timvandermeij
changed the title
timvandermeij
changed the title
|
Thank you for fixing this! /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://3.101.106.178:8877/81a576ae607bb45/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/933a9f427d3c2c0/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/933a9f427d3c2c0/output.txt Total script time: 24.85 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/81a576ae607bb45/output.txt Total script time: 25.94 mins
|
|
/botio-linux makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/20cf4a0032200ae/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/20cf4a0032200ae/output.txt Total script time: 24.90 mins
|
The display layer for annotation did not consider the font size in input fields.
I added the parsing and assigning of the font size of the input field. Aside from my own issues of PDFs not beeing correctly rendered on Screen, this fixes the too large rendered text fields in issue #7367 as well as the too small rendered text field in issue #11199 .
I did not change any rendering steps, as the font size seems to be considered there. One remaining issue are fields with font size "auto" which corresponds to size 0.
Fixes #7367.
Fixes #11199.