Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few *safe* ESLint no-var failures in src/core/evaluator.js (13371 follow-up) #13387

Merged
merged 1 commit into from
May 16, 2021
Merged

Fix a few *safe* ESLint no-var failures in src/core/evaluator.js (13371 follow-up) #13387

merged 1 commit into from
May 16, 2021

Commits on May 16, 2021

  1. Fix a few *safe* ESLint no-var failures in src/core/evaluator.js … 

    …(13371 follow-up)

As can be seen in PR 13371, some of the `no-var` changes in the `PartialEvaluator.{getOperatorList, getTextContent}` methods caused errors in `gulp server`-mode.
However, there's a handful of instances of `var` in other methods which should be completely *safe* to convert since there's no strange scope-issues present in that code.
    @Snuffleupagus
    Snuffleupagus committed May 16, 2021
    Configuration menu
    Copy the full SHA
    718f7bf View commit details
    Browse the repository at this point in the history