Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFA - Fix lot of layout issues #13402

Merged
merged 1 commit into from
May 25, 2021
Merged

Conversation

calixteman
Copy link
Contributor

  • I thought it was possible to rely on browser layout engine to handle layout stuff but it isn't possible
    • mainly because when a contentArea overflows, we must continue to layout in the next contentArea
    • when no more contentArea is available then we must go to the next page...
    • we must handle breakBefore and breakAfter which allows to "break" the layout to go to the next container
  • Sometimes some containers don't provide their dimensions so we must compute them in order to know where to put
    them in their parents but to compute those dimensions we need to layout the container itself...
  • See top of file layout.js for more explanations about layout.
  • fix few bugs in other places I met during my work on layout.

src/core/xfa/layout.js Outdated Show resolved Hide resolved
src/core/xfa/utils.js Outdated Show resolved Hide resolved
src/core/xfa/template.js Outdated Show resolved Hide resolved
Copy link
Contributor

@brendandahl brendandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ needs the comment in layout.js updated though.

  - I thought it was possible to rely on browser layout engine to handle layout stuff but it isn't possible
    - mainly because when a contentArea overflows, we must continue to layout in the next contentArea
    - when no more contentArea is available then we must go to the next page...
    - we must handle breakBefore and breakAfter which allows to "break" the layout to go to the next container
  - Sometimes some containers don't provide their dimensions so we must compute them in order to know where to put
    them in their parents but to compute those dimensions we need to layout the container itself...
  - See top of file layout.js for more explanations about layout.
  - fix few bugs in other places I met during my work on layout.
@calixteman
Copy link
Contributor Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/b1eeef2bfa5009d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/783a046d416a15c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/b1eeef2bfa5009d/output.txt

Total script time: 0.00 mins

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/783a046d416a15c/output.txt

Total script time: 5.64 mins

  • Unit Tests: Passed

@calixteman
Copy link
Contributor Author

/botio-linux unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1ba657f6ce2cbe3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/1ba657f6ce2cbe3/output.txt

Total script time: 0.00 mins

@calixteman
Copy link
Contributor Author

/botio-linux unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/7ff2c8ada75a912/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/7ff2c8ada75a912/output.txt

Total script time: 3.02 mins

  • Unit Tests: Passed

@calixteman calixteman merged commit 4d26623 into mozilla:master May 25, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants