Support strokeAlpha/fillAlpha when creating a fallback appearance stream (issue 6810) #13448
Conversation
Snuffleupagus
force-pushed
the
_setDefaultAppearance-alpha
branch
7 times, most recently
from
761cacf
to
d792193
Compare
Snuffleupagus
force-pushed
the
_setDefaultAppearance-alpha
branch
4 times, most recently
from
591e52b
to
c58d816
Compare
Snuffleupagus
force-pushed
the
_setDefaultAppearance-alpha
branch
from
c58d816
to
58a8c49
Compare
…eam (issue 6810) This fixes the colours, by respecting the strokeAlpha/fillAlpha-values, for a couple of Annotations in the PDF document from issue 13447.[1] --- [1] Some of the annotations still won't render at all, when compared with Adobe Reader, but that could/should probably be handled separately.
…ries (issue 13447) This extends PR 13106 to apply not only to empty /Rect-entries, but also to bogus /Rect-entries for various Annotation-types.
Snuffleupagus
force-pushed
the
_setDefaultAppearance-alpha
branch
from
58a8c49
to
52c1332
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/618819bc9e6fa1e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/618819bc9e6fa1e/output.txt Total script time: 25.96 mins
Image differences available at: http://54.67.70.0:8877/618819bc9e6fa1e/reftest-analyzer.html#web=eq.log |
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/4d957a53c602755/output.txt |
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/4d957a53c602755/output.txt Total script time: 7.25 mins Published |
|
Thank you for fixing this, also for the other markup annotation types that according to the spec also support the CA property! I forgot about CA before since I had no test cases that actually used it and I also postponed custom line endings because they seemed very rare. /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/60904143b35aadc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 2 Live output at: http://3.101.106.178:8877/f94fa333654b257/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/60904143b35aadc/output.txt Total script time: 22.80 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/f94fa333654b257/output.txt Total script time: 27.03 mins
|
Fixes most of issue #13447; with only two things remaining (that I won't attempt here):
/LE-entries (line endings) in LineAnnotations, assuming we care about that.With this patch, while we still don't match Adobe Reader perfectly, we're doing a much better job overall than e.g. PDFium since all Annotations are now at least visible in the viewer.
For some Annotation-types without an included appearance stream, it definitely feels like we're getting into the territory of diminishing returns w.r.t. adding even more special-cases. At some point, it's feels very tempting to simply blame PDF generators for using more "exotic" Annotations and failing to including an appearance stream.