XFA - Add the possibily to layout and measure text #13560

calixteman · 2021-06-14T19:53:37Z

some containers doesn't always have their 2 dimensions and those dimensions re based on contents;
so in order to measure text, we must get the glyph widths (for the xfa fonts) before starting the layout;
implement a word-wrap algorithm;
handle font change during text layout.

src/core/worker.js

src/core/xfa/factory.js

marco-c · 2021-06-14T23:00:34Z

I'm assuming this is going to fix #13500?

brendandahl · 2021-06-15T00:20:55Z

/botio test

pdfjsbot · 2021-06-15T00:20:56Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/024157c707184a9/output.txt

pdfjsbot · 2021-06-15T00:20:57Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/44b592f323a5d15/output.txt

pdfjsbot · 2021-06-15T00:23:28Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/024157c707184a9/output.txt

Total script time: 2.52 mins

Font tests: Passed
Unit tests: FAILED
Integration Tests: FAILED
Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/024157c707184a9/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-06-15T00:24:30Z

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/44b592f323a5d15/output.txt

Total script time: 3.54 mins

Font tests: Passed
Unit tests: FAILED
Integration Tests: FAILED
Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/44b592f323a5d15/reftest-analyzer.html#web=eq.log

brendandahl · 2021-06-15T20:37:04Z

/botio test

pdfjsbot · 2021-06-15T20:37:05Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c0bedb569dd739b/output.txt

pdfjsbot · 2021-06-15T20:37:05Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/74415f0a80f3f8e/output.txt

pdfjsbot · 2021-06-15T21:04:17Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/c0bedb569dd739b/output.txt

Total script time: 27.19 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/c0bedb569dd739b/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-06-15T21:07:54Z

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/74415f0a80f3f8e/output.txt

Total script time: 30.81 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/74415f0a80f3f8e/reftest-analyzer.html#web=eq.log

marco-c · 2021-06-15T21:08:52Z

There seems to be a regression at least in firefox-hsbc_closure-page1.

calixteman · 2021-06-16T15:09:40Z

/botio test

pdfjsbot · 2021-06-16T15:09:41Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/177fa5d3b897f54/output.txt

pdfjsbot · 2021-06-16T15:09:41Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/4c16fe39c8af849/output.txt

calixteman · 2021-06-16T15:23:41Z

/botio test

pdfjsbot · 2021-06-16T15:23:43Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.67.70.0:8877/d3a567ff2d330b5/output.txt

pdfjsbot · 2021-06-16T15:23:43Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/e67cda9f6da3d13/output.txt

pdfjsbot · 2021-06-16T15:36:39Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/177fa5d3b897f54/output.txt

Total script time: 26.96 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/177fa5d3b897f54/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-06-16T15:42:31Z

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/4c16fe39c8af849/output.txt

Total script time: 30.92 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/4c16fe39c8af849/reftest-analyzer.html#web=eq.log

calixteman · 2021-06-16T15:51:05Z

There is still an issue with hsbc_closure-page3 so I slightly increase the width factor from 1.1 to 1.2.

calixteman · 2021-06-16T15:51:21Z

/botio test

marco-c · 2021-06-16T16:10:27Z

There is still an issue with hsbc_closure-page3 so I slightly increase the width factor from 1.1 to 1.2.

There's still a minor issue ("IBAN:" the ":" is on the following line)

pdfjsbot · 2021-06-16T16:13:30Z

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/e67cda9f6da3d13/output.txt

Total script time: 30.99 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/e67cda9f6da3d13/reftest-analyzer.html#web=eq.log

calixteman · 2021-06-16T16:47:33Z

I don't understand why the issue is still there (hsbc_closure-page3)...
Normally the font used to render the "Non" (bottom left) is Arial and is embedded in the pdf.
And on my screen at least the "o" is almost a circle when I load the pdf locally when it isn't really a circle on the images reftest.
So maybe something is wrong with fonts in xfa reftests, I need to investigate.

calixteman · 2021-06-16T16:53:09Z

And of course I cannot reproduce locally, it seems that the font is correct.
The "O" are not the same from this png I generated locally.

pdfjsbot · 2021-06-16T16:57:46Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/9cd47a464f4a55c/output.txt

Total script time: 26.98 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/9cd47a464f4a55c/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-06-16T17:16:32Z

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/85cb04cfc9308b6/output.txt

Total script time: 31.47 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/85cb04cfc9308b6/reftest-analyzer.html#web=eq.log

calixteman · 2021-06-16T17:18:49Z

Finally tests are ok...

src/core/worker.js

src/core/xfa/template.js

calixteman · 2021-06-17T11:54:33Z

/botio test

pdfjsbot · 2021-06-17T11:54:34Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/17e1eb3dd9e005a/output.txt

pdfjsbot · 2021-06-17T11:54:34Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/160bd29fb06f467/output.txt

- some containers doesn't always have their 2 dimensions and those dimensions re based on contents; - so in order to measure text, we must get the glyph widths (for the xfa fonts) before starting the layout; - implement a word-wrap algorithm; - handle font change during text layout.

pdfjsbot · 2021-06-17T12:21:46Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/17e1eb3dd9e005a/output.txt

Total script time: 27.19 mins

Font tests: Passed
Unit tests: FAILED
Integration Tests: Passed
Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/17e1eb3dd9e005a/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-06-17T12:24:52Z

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/160bd29fb06f467/output.txt

Total script time: 30.29 mins

Font tests: Passed
Unit tests: FAILED
Integration Tests: Passed
Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/160bd29fb06f467/reftest-analyzer.html#web=eq.log

calixteman · 2021-06-17T12:43:56Z

/botio unittest

pdfjsbot · 2021-06-17T12:43:57Z

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e95ad44d312a2eb/output.txt

pdfjsbot · 2021-06-17T12:43:57Z

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/eaacfbaeb2c1a38/output.txt

pdfjsbot · 2021-06-17T12:47:51Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/e95ad44d312a2eb/output.txt

Total script time: 3.88 mins

Unit Tests: Passed

pdfjsbot · 2021-06-17T12:49:22Z

From: Bot.io (Windows)

Success

Full output at http://3.101.106.178:8877/eaacfbaeb2c1a38/output.txt

Total script time: 5.40 mins

Unit Tests: Passed

calixteman · 2021-06-17T13:06:28Z

/botio makeref

pdfjsbot · 2021-06-17T13:06:30Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e677da5b09a9d75/output.txt

pdfjsbot · 2021-06-17T13:06:30Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/aa321c218461a20/output.txt

pdfjsbot · 2021-06-17T13:30:06Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/e677da5b09a9d75/output.txt

Total script time: 23.60 mins

Lint: Passed
Make references: FAILED

pdfjsbot · 2021-06-17T13:38:45Z

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/aa321c218461a20/output.txt

Total script time: 27.33 mins

Lint: Passed
Make references: FAILED

calixteman requested a review from brendandahl June 14, 2021 19:53

Snuffleupagus reviewed Jun 14, 2021

View reviewed changes

src/core/worker.js Outdated Show resolved Hide resolved

src/core/xfa/factory.js Outdated Show resolved Hide resolved

calixteman force-pushed the xfa_font_widths branch from 335636e to 4f718fa Compare June 14, 2021 20:18

marco-c added the form-xfa label Jun 14, 2021

marco-c linked an issue Jun 14, 2021 that may be closed by this pull request

XFA use of CDATA in exData section causes unhandled exception #13500

Open

calixteman force-pushed the xfa_font_widths branch from 4f718fa to 304bea8 Compare June 15, 2021 18:36

calixteman force-pushed the xfa_font_widths branch from 304bea8 to 4e75b6f Compare June 16, 2021 14:52

calixteman force-pushed the xfa_font_widths branch from 4e75b6f to e8e88d5 Compare June 16, 2021 15:49

marco-c reviewed Jun 17, 2021

View reviewed changes

src/core/worker.js Outdated Show resolved Hide resolved

marco-c reviewed Jun 17, 2021

View reviewed changes

src/core/xfa/template.js Outdated Show resolved Hide resolved

marco-c approved these changes Jun 17, 2021

View reviewed changes

calixteman force-pushed the xfa_font_widths branch from e8e88d5 to c8a493f Compare June 17, 2021 11:54

calixteman force-pushed the xfa_font_widths branch from c8a493f to 8eeb7ab Compare June 17, 2021 12:17

calixteman merged commit b300aba into mozilla:master Jun 17, 2021

timvandermeij removed the request for review from brendandahl June 18, 2021 18:57

XFA - Add the possibily to layout and measure text #13560

XFA - Add the possibily to layout and measure text #13560

Conversation

calixteman commented Jun 14, 2021

marco-c commented Jun 14, 2021

brendandahl commented Jun 15, 2021

pdfjsbot commented Jun 15, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 15, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Jun 15, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Jun 15, 2021

From: Bot.io (Windows)

Failed

brendandahl commented Jun 15, 2021

pdfjsbot commented Jun 15, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 15, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Jun 15, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Jun 15, 2021

From: Bot.io (Windows)

Failed

marco-c commented Jun 15, 2021

calixteman commented Jun 16, 2021

pdfjsbot commented Jun 16, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 16, 2021

From: Bot.io (Windows)

Received

calixteman commented Jun 16, 2021

pdfjsbot commented Jun 16, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 16, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Jun 16, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Jun 16, 2021

From: Bot.io (Windows)

Failed

calixteman commented Jun 16, 2021 • edited Loading

calixteman commented Jun 16, 2021

marco-c commented Jun 16, 2021

pdfjsbot commented Jun 16, 2021

From: Bot.io (Windows)

Failed

calixteman commented Jun 16, 2021

calixteman commented Jun 16, 2021

pdfjsbot commented Jun 16, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Jun 16, 2021

From: Bot.io (Windows)

Failed

calixteman commented Jun 16, 2021

calixteman commented Jun 17, 2021

pdfjsbot commented Jun 17, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 17, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Jun 17, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Jun 17, 2021

From: Bot.io (Windows)

Failed

calixteman commented Jun 16, 2021 •

edited

Loading