Use async a bit more in the API
#13943
Conversation
This patch changes the `PDFDocumentLoadingTask.destroy`-method and the `_fetchDocument`-function to be `async`, which slightly simplifies the relevant code. Furthermore, remove the catch-handler from the `WorkerTransport.getPageIndex`-method since it's no longer needed. Given that the `MessageHandler` is nowadays wrapping every possible Exception, it's no longer necessary to try and re-wrap the reason here.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9025fc7118d9a8e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/b21c9f4654e4225/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9025fc7118d9a8e/output.txt Total script time: 3.77 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/b21c9f4654e4225/output.txt Total script time: 5.47 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4bced44cea9b7db/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/2b9a65a48c88ed8/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/4bced44cea9b7db/output.txt Total script time: 4.37 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/2b9a65a48c88ed8/output.txt Total script time: 5.72 mins
|
|
Looks good! |
This patch changes the
PDFDocumentLoadingTask.destroy-method and the_fetchDocument-function to beasync, which slightly simplifies the relevant code.Furthermore, remove the catch-handler from the
WorkerTransport.getPageIndex-method since it's no longer needed. Given that theMessageHandleris nowadays wrapping every possible Exception, it's no longer necessary to try and re-wrap the reason here.