-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XFA - Don't create images for unsupported mime types #14018
Conversation
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.241.84.105:8877/135d0ef444fc8ba/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d7b999e41b94784/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/135d0ef444fc8ba/output.txt Total script time: 20.86 mins
Image differences available at: http://54.241.84.105:8877/135d0ef444fc8ba/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d7b999e41b94784/output.txt Total script time: 40.96 mins
Image differences available at: http://54.193.163.58:8877/d7b999e41b94784/reftest-analyzer.html#web=eq.log |
I didn't look at all the failures, but several of them have blank content types. In those cases to the files do have gif/jpg file extensions, but I wonder if it'd be better to look for a magic number. A different bug is xfa_issue13633-page1, it has content type of "image/PNG", so we'll probably want to lowercase the string comparison. |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2dede6271d56c2d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f0f9ad3f2a46674/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/2dede6271d56c2d/output.txt Total script time: 23.32 mins
Image differences available at: http://54.241.84.105:8877/2dede6271d56c2d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f0f9ad3f2a46674/output.txt Total script time: 40.32 mins
Image differences available at: http://54.193.163.58:8877/f0f9ad3f2a46674/reftest-analyzer.html#web=eq.log |
No description provided.