Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFA - Don't create images for unsupported mime types #14018

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

calixteman
Copy link
Contributor

No description provided.

@brendandahl
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/135d0ef444fc8ba/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d7b999e41b94784/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/135d0ef444fc8ba/output.txt

Total script time: 20.86 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  errors: 595
  different ref/snapshot: 35

Image differences available at: http://54.241.84.105:8877/135d0ef444fc8ba/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/d7b999e41b94784/output.txt

Total script time: 40.96 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 37
  different first/second rendering: 2

Image differences available at: http://54.193.163.58:8877/d7b999e41b94784/reftest-analyzer.html#web=eq.log

@brendandahl
Copy link
Contributor

I didn't look at all the failures, but several of them have blank content types. In those cases to the files do have gif/jpg file extensions, but I wonder if it'd be better to look for a magic number. A different bug is xfa_issue13633-page1, it has content type of "image/PNG", so we'll probably want to lowercase the string comparison.

@brendandahl
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2dede6271d56c2d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f0f9ad3f2a46674/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/2dede6271d56c2d/output.txt

Total script time: 23.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 12
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/2dede6271d56c2d/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/f0f9ad3f2a46674/output.txt

Total script time: 40.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 2

Image differences available at: http://54.193.163.58:8877/f0f9ad3f2a46674/reftest-analyzer.html#web=eq.log

@brendandahl brendandahl merged commit 7fb653b into mozilla:master Sep 14, 2021
@timvandermeij timvandermeij removed the request for review from brendandahl September 15, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants