Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GENERIC viewer] Warn about AppOptions being overridden by Preferences during loading #14063

Merged
merged 1 commit into from
Sep 22, 2021
Merged

[GENERIC viewer] Warn about AppOptions being overridden by Preferences during loading #14063

merged 1 commit into from
Sep 22, 2021

Commits on Sep 22, 2021

  1. [GENERIC viewer] Warn about AppOptions being overridden by Preference… 

    …s during loading

Currently any AppOptions set using e.g. the "webviewerloaded" event listener can/will by default be overridden when the Preferences are read.
To avoid that happening the "disablePreferences"-option can be used, however unless it's been explicitly set all non-default AppOptions will be silently ignored. This patch thus attempts to improve the current situation somewhat, for third-party implementations, by logging a warning in the console when this happens.
    @Snuffleupagus
    Snuffleupagus committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    96b38f6 View commit details
    Browse the repository at this point in the history