XFA - Add <a> element in button when an url is detected (bug 1716758) #14076

calixteman · 2021-09-25T13:31:42Z

it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1716758;
some buttons have a JS action with the pattern app.launchURL(...) (or similar) so extract when it's possible the url and generate a element with the href equals to the found url;
pdf.js already had some code to handle that so this patch slightly refactor that.

src/shared/util.js

src/core/catalog.js

Snuffleupagus · 2021-09-25T15:52:20Z

/botio test

pdfjsbot · 2021-09-25T15:52:21Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5db7c2d197cc0c8/output.txt

pdfjsbot · 2021-09-25T15:52:21Z

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/534562f106dc040/output.txt

pdfjsbot · 2021-09-25T16:12:40Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/5db7c2d197cc0c8/output.txt

Total script time: 20.31 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  errors: 600
  different ref/snapshot: 6

Image differences available at: http://54.241.84.105:8877/5db7c2d197cc0c8/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-09-25T16:32:41Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/534562f106dc040/output.txt

Total script time: 40.33 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 4
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/534562f106dc040/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2021-09-25T17:01:41Z

/botio-linux browsertest

pdfjsbot · 2021-09-25T17:01:42Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b338d7b8277d8e9/output.txt

pdfjsbot · 2021-09-25T17:19:11Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b338d7b8277d8e9/output.txt

Total script time: 17.47 mins

Regression tests: FAILED

  errors: 621
  different ref/snapshot: 4
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/b338d7b8277d8e9/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2021-09-25T17:40:34Z

/botio-linux browsertest

pdfjsbot · 2021-09-25T17:40:35Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/54e8329e94e02f8/output.txt

pdfjsbot · 2021-09-25T18:11:40Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/54e8329e94e02f8/output.txt

Total script time: 19.25 mins

Regression tests: FAILED

  different ref/snapshot: 9
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/54e8329e94e02f8/reftest-analyzer.html#web=eq.log

Snuffleupagus

r=me, looks good to me with the comment addressed; thank you!

Snuffleupagus · 2021-09-25T18:28:27Z

test/unit/xfa_tohtml_spec.js

+
+    const pages = factory.getPages();
+    const a = searchHtmlNode(pages, "name", "a");
+    expect(a.attributes.href).toEqual("https://github.com/mozilla/pdf.js");


Can you please add a check to ensure that the target is also correct, since you're using the "app.launchURL(...)" format to specify the URL?

- it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1716758; - some buttons have a JS action with the pattern `app.launchURL(...)` (or similar) so extract when it's possible the url and generate a <a> element with the href equals to the found url; - pdf.js already had some code to handle that so this patch slightly refactor that.

calixteman · 2021-09-25T20:00:06Z

/botio unittest

pdfjsbot · 2021-09-25T20:00:08Z

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 2

Live output at: http://54.241.84.105:8877/1be51b0f61f58ea/output.txt

pdfjsbot · 2021-09-25T20:00:08Z

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 2

Live output at: http://54.193.163.58:8877/c2fae6b90cfe56a/output.txt

test/unit/xfa_tohtml_spec.js

pdfjsbot · 2021-09-25T20:25:04Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1be51b0f61f58ea/output.txt

Total script time: 2.81 mins

Unit Tests: Passed

pdfjsbot · 2021-09-25T21:05:48Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/c2fae6b90cfe56a/output.txt

Total script time: 5.62 mins

Unit Tests: Passed

Snuffleupagus reviewed Sep 25, 2021

View reviewed changes

src/shared/util.js Outdated Show resolved Hide resolved

src/shared/util.js Outdated Show resolved Hide resolved

src/core/catalog.js Outdated Show resolved Hide resolved

calixteman force-pushed the 1716758 branch from 159696e to 9671383 Compare September 25, 2021 15:25

Snuffleupagus approved these changes Sep 25, 2021

View reviewed changes

calixteman force-pushed the 1716758 branch from 9671383 to 558e58f Compare September 25, 2021 19:59

Snuffleupagus reviewed Sep 25, 2021

View reviewed changes

test/unit/xfa_tohtml_spec.js Show resolved Hide resolved

Snuffleupagus merged commit 3b3c487 into mozilla:master Sep 26, 2021

timvandermeij added the form-xfa label Sep 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XFA - Add <a> element in button when an url is detected (bug 1716758) #14076

XFA - Add <a> element in button when an url is detected (bug 1716758) #14076

calixteman commented Sep 25, 2021

Snuffleupagus commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

Snuffleupagus commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

Snuffleupagus commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

Snuffleupagus left a comment

Snuffleupagus Sep 25, 2021

calixteman commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

XFA - Add <a> element in button when an url is detected (bug 1716758) #14076

XFA - Add <a> element in button when an url is detected (bug 1716758) #14076

Conversation

calixteman commented Sep 25, 2021

Snuffleupagus commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Sep 25, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Sep 25, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Sep 25, 2021

From: Bot.io (Windows)

Failed

Snuffleupagus commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Sep 25, 2021

From: Bot.io (Linux m4)

Failed

Snuffleupagus commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Sep 25, 2021

From: Bot.io (Linux m4)

Failed

Snuffleupagus left a comment

Choose a reason for hiding this comment

Snuffleupagus Sep 25, 2021

Choose a reason for hiding this comment

calixteman commented Sep 25, 2021

pdfjsbot commented Sep 25, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Sep 25, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Sep 25, 2021

From: Bot.io (Linux m4)

Success

pdfjsbot commented Sep 25, 2021

From: Bot.io (Windows)

Success