Re-factor the Catalog.viewerPreferences method and remove the isBool helper function
#14598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `ViewerPreferencesValidators` structure, and thus (slightly) simplifies the code overall. With these changes we only have to iterate through, and validate, the actually available Dictionary entries.
The call-sites are replaced by direct `typeof`-checks instead, which removes unnecessary function calls.
Snuffleupagus
force-pushed
the
rm-isBool
branch
from
fcfda60
to
3704283
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8d25b4195fe4001/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3792a1b9fecbb1d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3792a1b9fecbb1d/output.txt Total script time: 24.15 mins
Image differences available at: http://54.241.84.105:8877/3792a1b9fecbb1d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8d25b4195fe4001/output.txt Total script time: 24.91 mins
|
timvandermeij
approved these changes
Feb 23, 2022
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-factor the
Catalog.viewerPreferencesmethodThis removes the
ViewerPreferencesValidatorsstructure, and thus (slightly) simplifies the code overall. With these changes we only have to iterate through, and validate, the actually available Dictionary entries.Remove the
isBoolhelper functionThe call-sites are replaced by direct
typeof-checks instead, which removes unnecessary function calls.