[Annotations] Add support for printing/saving choice list with multiple selections #14720

calixteman · 2022-03-26T21:47:57Z

it aims to fix issue Implement printing/saving support for listboxes #12189.

calixteman · 2022-03-26T21:48:29Z

/botio test

pdfjsbot · 2022-03-26T21:48:30Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ccca9d05f1505ce/output.txt

pdfjsbot · 2022-03-26T21:48:30Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0516785a8ad10dd/output.txt

pdfjsbot · 2022-03-26T22:12:01Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/0516785a8ad10dd/output.txt

Total script time: 23.50 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 10
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/0516785a8ad10dd/reftest-analyzer.html#web=eq.log

pdfjsbot · 2022-03-26T22:15:11Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/ccca9d05f1505ce/output.txt

Total script time: 26.67 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/ccca9d05f1505ce/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2022-03-27T10:52:38Z

Looking at the annotation-choice-widget-print-page1 test results, I'm wondering if the empty "List box, read-only"-part makes sense here? More specifically, since that element ought to be read-only, should we perhaps remove the following part of the manifest such that we actually test printing of the read-only element:

pdf.js/test/test_manifest.json

Lines 5902 to 5904 in db4f3ad

    
           "63R": { 
        
             "value": "" 
        
           }

calixteman · 2022-03-27T11:39:41Z

/botio test

pdfjsbot · 2022-03-27T11:39:42Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/30e6befd11c4fc0/output.txt

pdfjsbot · 2022-03-27T11:39:42Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/aa316faeb3c51f4/output.txt

pdfjsbot · 2022-03-27T12:03:20Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/30e6befd11c4fc0/output.txt

Total script time: 23.62 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 10
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/30e6befd11c4fc0/reftest-analyzer.html#web=eq.log

pdfjsbot · 2022-03-27T12:05:58Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/aa316faeb3c51f4/output.txt

Total script time: 26.25 mins

Font tests: Passed
Unit tests: FAILED
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/aa316faeb3c51f4/reftest-analyzer.html#web=eq.log

Snuffleupagus

r=me, with a couple of small comments.

src/core/annotation.js

test/test_manifest.json

calixteman · 2022-03-29T16:54:44Z

/botio test

pdfjsbot · 2022-03-29T16:54:46Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a36c82bed903a81/output.txt

pdfjsbot · 2022-03-29T16:54:46Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fe4ba8868392e27/output.txt

…le selections - it aims to fix issue mozilla#12189.

pdfjsbot · 2022-03-29T17:18:28Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/a36c82bed903a81/output.txt

Total script time: 23.69 mins

Font tests: Passed
Unit tests: FAILED
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 12
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/a36c82bed903a81/reftest-analyzer.html#web=eq.log

pdfjsbot · 2022-03-29T17:20:58Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/fe4ba8868392e27/output.txt

Total script time: 26.20 mins

Font tests: Passed
Unit tests: FAILED
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/fe4ba8868392e27/reftest-analyzer.html#web=eq.log

calixteman · 2022-03-29T18:25:50Z

/botio unittest

pdfjsbot · 2022-03-29T18:25:52Z

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/cc10b3b6da2a00a/output.txt

pdfjsbot · 2022-03-29T18:25:52Z

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/31163f8e7d60bbc/output.txt

pdfjsbot · 2022-03-29T18:28:55Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/cc10b3b6da2a00a/output.txt

Total script time: 3.05 mins

Unit Tests: Passed

pdfjsbot · 2022-03-29T18:32:13Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/31163f8e7d60bbc/output.txt

Total script time: 6.34 mins

Unit Tests: Passed

calixteman · 2022-03-30T09:12:30Z

/botio makeref

pdfjsbot · 2022-03-30T09:12:31Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/450dcd9f8f6ad65/output.txt

pdfjsbot · 2022-03-30T09:12:31Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/ceac16200f9f9a2/output.txt

pdfjsbot · 2022-03-30T09:33:12Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/450dcd9f8f6ad65/output.txt

Total script time: 20.67 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2022-03-30T09:37:16Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/ceac16200f9f9a2/output.txt

Total script time: 21.35 mins

Lint: Passed
Make references: Passed
Check references: Passed

nmtigor · 2022-06-02T16:32:52Z

src/core/annotation.js

+      let lineWidth = -1;
+      let value;
+      for (const { displayValue } of this.data.options) {
+        const width = this._getTextWidth(displayValue);


Should this be

const width = this._getTextWidth(displayValue, font);

calixteman added the annotations label Mar 26, 2022

calixteman requested review from Snuffleupagus and timvandermeij March 26, 2022 21:48

Snuffleupagus linked an issue Mar 27, 2022 that may be closed by this pull request

Implement printing/saving support for listboxes #12189

Closed

Snuffleupagus added the form-acroform label Mar 27, 2022

calixteman force-pushed the 12189 branch from 9001371 to 403bcc4 Compare March 27, 2022 11:39

Snuffleupagus approved these changes Mar 29, 2022

View reviewed changes

src/core/annotation.js Outdated Show resolved Hide resolved

src/core/annotation.js Outdated Show resolved Hide resolved

src/core/annotation.js Outdated Show resolved Hide resolved

src/core/annotation.js Outdated Show resolved Hide resolved

test/test_manifest.json Show resolved Hide resolved

calixteman force-pushed the 12189 branch from 403bcc4 to 2ca9d21 Compare March 29, 2022 16:53

[Annotations] Add support for printing/saving choice list with multip…

ad3fb71

…le selections - it aims to fix issue mozilla#12189.

calixteman force-pushed the 12189 branch from 2ca9d21 to ad3fb71 Compare March 29, 2022 16:59

calixteman merged commit 4d4c67d into mozilla:master Mar 30, 2022

timvandermeij removed their request for review April 1, 2022 18:42

Snuffleupagus mentioned this pull request May 8, 2022

Time for a new release? #14892

Closed

nmtigor reviewed Jun 6, 2022

View reviewed changes

Snuffleupagus mentioned this pull request Jun 9, 2022

Fix a couple of old review comments #15011

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Annotations] Add support for printing/saving choice list with multiple selections #14720

[Annotations] Add support for printing/saving choice list with multiple selections #14720

calixteman commented Mar 26, 2022

calixteman commented Mar 26, 2022

pdfjsbot commented Mar 26, 2022

pdfjsbot commented Mar 26, 2022

pdfjsbot commented Mar 26, 2022

pdfjsbot commented Mar 26, 2022

Snuffleupagus commented Mar 27, 2022

calixteman commented Mar 27, 2022

pdfjsbot commented Mar 27, 2022

pdfjsbot commented Mar 27, 2022

pdfjsbot commented Mar 27, 2022

pdfjsbot commented Mar 27, 2022

Snuffleupagus left a comment

calixteman commented Mar 29, 2022

pdfjsbot commented Mar 29, 2022

pdfjsbot commented Mar 29, 2022

pdfjsbot commented Mar 29, 2022

pdfjsbot commented Mar 29, 2022

calixteman commented Mar 29, 2022

pdfjsbot commented Mar 29, 2022

pdfjsbot commented Mar 29, 2022

pdfjsbot commented Mar 29, 2022

pdfjsbot commented Mar 29, 2022

calixteman commented Mar 30, 2022

pdfjsbot commented Mar 30, 2022

pdfjsbot commented Mar 30, 2022

pdfjsbot commented Mar 30, 2022

pdfjsbot commented Mar 30, 2022

nmtigor Jun 2, 2022

[Annotations] Add support for printing/saving choice list with multiple selections #14720

[Annotations] Add support for printing/saving choice list with multiple selections #14720

Conversation

calixteman commented Mar 26, 2022

calixteman commented Mar 26, 2022

pdfjsbot commented Mar 26, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented Mar 26, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Mar 26, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Mar 26, 2022

From: Bot.io (Windows)

Failed

Snuffleupagus commented Mar 27, 2022

calixteman commented Mar 27, 2022

pdfjsbot commented Mar 27, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Mar 27, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented Mar 27, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Mar 27, 2022

From: Bot.io (Windows)

Failed

Snuffleupagus left a comment

Choose a reason for hiding this comment

calixteman commented Mar 29, 2022

pdfjsbot commented Mar 29, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Mar 29, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented Mar 29, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Mar 29, 2022

From: Bot.io (Windows)

Failed

calixteman commented Mar 29, 2022

pdfjsbot commented Mar 29, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Mar 29, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented Mar 29, 2022

From: Bot.io (Linux m4)

Success

pdfjsbot commented Mar 29, 2022

From: Bot.io (Windows)

Success

calixteman commented Mar 30, 2022

pdfjsbot commented Mar 30, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Mar 30, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented Mar 30, 2022

From: Bot.io (Linux m4)

Success

pdfjsbot commented Mar 30, 2022

From: Bot.io (Windows)

Success

nmtigor Jun 2, 2022

Choose a reason for hiding this comment