Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode non-ASCII values found in the xfa:datasets (PR 14735 follow-up) #14738

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

Please note: This is possibly bad/wrong in general, but I figured that submitting it for review wouldn't hurt.

It seems that even Adobe Reader doesn't handle the non-ASCII characters that appear in some of the fields correctly, however it should be pretty easy to improve things on the PDF.js side.

*Please note:* This is possibly bad/wrong in general, but I figured that submitting it for review wouldn't hurt.

It seems that even Adobe Reader doesn't handle the non-ASCII characters that appear in some of the fields correctly, however it should be pretty easy to improve things on the PDF.js side.
@calixteman
Copy link
Contributor

Eh eh, you've been faster than me: it was on my todo list.

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d617a21f0bfe0da/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/55e78b225ba1323/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/55e78b225ba1323/output.txt

Total script time: 23.69 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 11
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/55e78b225ba1323/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/d617a21f0bfe0da/output.txt

Total script time: 26.29 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 3

Image differences available at: http://54.193.163.58:8877/d617a21f0bfe0da/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit 38e9a46 into mozilla:master Apr 1, 2022
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/a27018a5e92dda9/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6f86234af4de02b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/6f86234af4de02b/output.txt

Total script time: 20.73 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/a27018a5e92dda9/output.txt

Total script time: 21.38 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the xfa-datasets-decode branch April 1, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDFJS is not able to show prefilled Acroform PDF with data in xfa:dataset
3 participants