Remove unnecessary print CSS rules
#14829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0f0f59ba9f2cb2a/output.txt |
These rules became unnecessary with PR 7697, over five years ago, since printing is now done from a `printContainer`-element rather than "directly" using the viewer. Note how the *entire* `outerContainer`, which contains all of the DOM elements that were being manually hidden, is now being hidden during printing. Furthermore, note also how the print-canvases/images and their containers are using custom CSS-classes[1] rather than re-using the ones from the viewer. --- [1] See the `printedPage` respectively `xfaPrintedPage` classes.
Snuffleupagus
force-pushed
the
rm-print-CSS
branch
from
a061ed7
to
925a7bc
Compare
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0f0f59ba9f2cb2a/output.txt Total script time: 2.55 mins Published |
timvandermeij
approved these changes
Apr 24, 2022
|
Nice clean-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rules became unnecessary with PR #7697, over five years ago, since printing is now done from a
printContainer-element rather than "directly" using the viewer.Note how the entire
outerContainer, which contains all of the DOM elements that were being manually hidden, is now being hidden during printing. Furthermore, note also how the print-canvases/images and their containers are using custom CSS-classes[1] rather than re-using the ones from the viewer.[1] See the
printedPagerespectivelyxfaPrintedPageclasses.