Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the es-module-shims dependency to version 1.4.7 #14861

Merged
merged 1 commit into from
May 1, 2022

Conversation

timvandermeij
Copy link
Contributor

Unfortunately newer versions either caused breakage when running the unit tests manually in a browser or when serving the development viewer. Given that we hope to use native import maps soon and this dependency will then be removed anyway, let's pin it for the time being.

Fixes #14860 (comment).

Unfortunately newer versions either caused breakage when running the
unit tests manually in a browser or when serving the development viewer.
Given that we hope to use native import maps soon and this dependency
will then be removed anyway, let's pin it for the time being.
@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented May 1, 2022

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/9481eab3c58be74/output.txt

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to be working locally, thanks for the quick fix!

@pdfjsbot
Copy link

pdfjsbot commented May 1, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/9481eab3c58be74/output.txt

Total script time: 2.85 mins

Published

@timvandermeij timvandermeij merged commit 397f714 into mozilla:master May 1, 2022
@timvandermeij timvandermeij deleted the es-module-shims branch May 1, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants