Commits on May 15, 2022

1. Remove the sourceEventType from the viewer (bug 1757771 follow-up) …

   After the changes in https://bugzilla.mozilla.org/show_bug.cgi?id=1757771, that simplified the MOZCENTRAL downloading code, the `sourceEventType` is now completely unused and should thus be removed (in my opinion).
   
   Furthermore, with these changes, we also no longer need a *separate* internal "save"-event and can instead just use the older "download"-event everywhere.

   

   Snuffleupagus committed May 15, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 4f1cd6a
   • Browse repository at this point

   Copy the full SHA

   4f1cd6a View commit details

   Browse the repository at this point in the history

2. [Firefox viewer] Stop using FirefoxCom.requestAsync in the `Downloa… …

   …dManager`
   
   After the changes in https://bugzilla.mozilla.org/show_bug.cgi?id=1757771, that simplified the MOZCENTRAL downloading code, the `ChromeActions.download`-method will no longer invoke the `sendResponse`-callback.
   Hence it should no longer be necessary for the `DownloadManager`, in the MOZCENTRAL viewer, to use `FirefoxCom.requestAsync` since no response is ever provided.[1] For the allocated BlobURLs, they should (hopefully) be released when navigating away from the viewer.
   
   ---
   [1] Note that that was *already* the case, for one of the previous code-paths in the `ChromeActions.download`-method.

   

   Snuffleupagus committed May 15, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 8a34980
   • Browse repository at this point

   Copy the full SHA

   8a34980 View commit details

   Browse the repository at this point in the history