-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip bogus d1
operators in Type3-glyphs (issue 14953)
#14955
Conversation
In the `src/display/canvas.js` code the `d1` operator will be used to set the clipping region, and it obviously cannot be empty since that prevents the Type3-glyph from rendering. Also, the patch removes an outdated comment; refer to PR 12718.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4fa2287b64c574b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4fa2287b64c574b/output.txt Total script time: 2.52 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6b0b7df22421460/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e9872751581f6bf/output.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6b0b7df22421460/output.txt Total script time: 26.38 mins
Image differences available at: http://54.241.84.105:8877/6b0b7df22421460/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e9872751581f6bf/output.txt Total script time: 28.14 mins
Image differences available at: http://54.193.163.58:8877/e9872751581f6bf/reftest-analyzer.html#web=eq.log |
All of the font-rendering failures in Firefox on the Linux-bot should already be tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1770706, and the same applies to the |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/436abfdd2c9d3ea/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2a987781252b692/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/2a987781252b692/output.txt Total script time: 21.76 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/436abfdd2c9d3ea/output.txt Total script time: 22.83 mins
|
In the
src/display/canvas.js
code thed1
operator will be used to set the clipping region, and it obviously cannot be empty since that prevents the Type3-glyph from rendering.Also, the patch removes an outdated comment; refer to PR #12718.