Support Hangul syllables when searching some text (bug 1771477) #14965

calixteman · 2022-05-28T12:12:52Z

it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1771477;
hangul contains some syllables which are decomposed when using NFD, hence
the text must be correctly shifted in case it contains some of them.

test/unit/pdf_find_controller_spec.js

web/pdf_find_controller.js

test/unit/pdf_find_controller_spec.js

Snuffleupagus · 2022-05-28T14:02:07Z

/botio unittest

pdfjsbot · 2022-05-28T14:02:08Z

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a02a4d28827230c/output.txt

pdfjsbot · 2022-05-28T14:02:08Z

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/921b47b285f64f0/output.txt

pdfjsbot · 2022-05-28T14:05:22Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/a02a4d28827230c/output.txt

Total script time: 3.21 mins

Unit Tests: FAILED

pdfjsbot · 2022-05-28T14:08:36Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/921b47b285f64f0/output.txt

Total script time: 6.44 mins

Unit Tests: Passed

Snuffleupagus · 2022-05-28T14:09:53Z

/botio integrationtest

pdfjsbot · 2022-05-28T14:09:54Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/74ef39b1ad3c979/output.txt

pdfjsbot · 2022-05-28T14:09:55Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d4ac20d503d2052/output.txt

pdfjsbot · 2022-05-28T14:14:21Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/74ef39b1ad3c979/output.txt

Total script time: 4.42 mins

Integration Tests: Passed

pdfjsbot · 2022-05-28T14:18:39Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/d4ac20d503d2052/output.txt

Total script time: 8.73 mins

Integration Tests: Passed

Snuffleupagus

r=me, with the final comment addressed; thank you!

web/pdf_find_controller.js

- it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1771477; - hangul contains some syllables which are decomposed when using NFD, hence the text must be correctly shifted in case it contains some of them.

calixteman · 2022-05-28T14:51:11Z

/botio unittest

pdfjsbot · 2022-05-28T14:51:12Z

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/71d9450d15c2119/output.txt

pdfjsbot · 2022-05-28T14:51:12Z

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9ae637244de1cfe/output.txt

pdfjsbot · 2022-05-28T14:54:25Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/9ae637244de1cfe/output.txt

Total script time: 3.19 mins

Unit Tests: FAILED

pdfjsbot · 2022-05-28T14:57:48Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/71d9450d15c2119/output.txt

Total script time: 6.59 mins

Unit Tests: Passed

calixteman · 2022-05-28T15:00:31Z

/botio integrationtest

pdfjsbot · 2022-05-28T15:00:32Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/2fd90867852500f/output.txt

pdfjsbot · 2022-05-28T15:00:33Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/03e340fce22ad1e/output.txt

pdfjsbot · 2022-05-28T15:24:48Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/2fd90867852500f/output.txt

Total script time: 4.45 mins

Integration Tests: Passed

pdfjsbot · 2022-05-28T15:33:02Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/03e340fce22ad1e/output.txt

Total script time: 7.09 mins

Integration Tests: Passed

calixteman added the text-selection label May 28, 2022

Snuffleupagus reviewed May 28, 2022

View reviewed changes

test/unit/pdf_find_controller_spec.js Show resolved Hide resolved

test/unit/pdf_find_controller_spec.js Show resolved Hide resolved

web/pdf_find_controller.js Outdated Show resolved Hide resolved

web/pdf_find_controller.js Outdated Show resolved Hide resolved

Snuffleupagus reviewed May 28, 2022

View reviewed changes

web/pdf_find_controller.js Outdated Show resolved Hide resolved

calixteman force-pushed the 1771477 branch from 159d3b3 to b8fb1d3 Compare May 28, 2022 13:01

calixteman requested a review from Snuffleupagus May 28, 2022 13:02

Snuffleupagus reviewed May 28, 2022

View reviewed changes

web/pdf_find_controller.js Outdated Show resolved Hide resolved

Snuffleupagus reviewed May 28, 2022

View reviewed changes

test/unit/pdf_find_controller_spec.js Outdated Show resolved Hide resolved

calixteman force-pushed the 1771477 branch from b8fb1d3 to 024a8b1 Compare May 28, 2022 13:57

Snuffleupagus approved these changes May 28, 2022

View reviewed changes

web/pdf_find_controller.js Outdated Show resolved Hide resolved

Support Hangul syllables when searching some text (bug 1771477)

c7afce4

- it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1771477; - hangul contains some syllables which are decomposed when using NFD, hence the text must be correctly shifted in case it contains some of them.

calixteman force-pushed the 1771477 branch from 024a8b1 to c7afce4 Compare May 28, 2022 14:50

calixteman merged commit 5b3fdee into mozilla:master May 28, 2022

calixteman deleted the 1771477 branch May 28, 2022 15:52

ZeroXClem mentioned this pull request Aug 12, 2024

[Snyk] Upgrade pdfjs-dist from 2.9.359 to 2.16.105 ZeroXClem/metamesa#3

Closed

earthywh mentioned this pull request Sep 24, 2024

[Snyk] Upgrade pdfjs-dist from 2.6.347 to 2.16.105 earthywh/filestash#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Hangul syllables when searching some text (bug 1771477) #14965

Support Hangul syllables when searching some text (bug 1771477) #14965

calixteman commented May 28, 2022

Snuffleupagus commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

Snuffleupagus commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

Snuffleupagus left a comment

calixteman commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

calixteman commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

Support Hangul syllables when searching some text (bug 1771477) #14965

Support Hangul syllables when searching some text (bug 1771477) #14965

Conversation

calixteman commented May 28, 2022

Snuffleupagus commented May 28, 2022

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Success

Snuffleupagus commented May 28, 2022

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Success

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Success

Snuffleupagus left a comment

Choose a reason for hiding this comment

calixteman commented May 28, 2022

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Success

calixteman commented May 28, 2022

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Success

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Success