[editor] Add support for saving newly added Ink #15006
Conversation
src/core/default_appearance.js
Outdated
| @@ -82,21 +82,24 @@ function parseDefaultAppearance(str) { | |||
| return new DefaultAppearanceEvaluator(str).parse(); | |||
| } | |||
|
|
|||
| function getPdfColor(color) { | |||
| function getPdfColor(color, g) { | |||
There was a problem hiding this comment.
Looking at the call-sites and this function itself, the new parameter feels somewhat confusing and difficult to understand.
How about using a binary parameter instead, e.g. function getPdfColor(color, isStroke = false) {, since that feels a lot clearer overall.
|
I forgot to run the unit tests. |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/518a1041ba3989d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 2 Live output at: http://54.193.163.58:8877/30ed649df8efe06/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/518a1041ba3989d/output.txt Total script time: 3.23 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/30ed649df8efe06/output.txt Total script time: 7.00 mins
|
No description provided.