Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill Array.prototype.at with core-js (PR 14976 follow-up) #15008

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

This Array-method is a fairly new addition to the ECMAScript specification, hence we need a polyfill to avoid the library/viewer breaking in older browsers.

Please find additional information at:

This Array-method is a fairly new addition to the ECMAScript specification, hence we need a polyfill to avoid the library/viewer breaking in older browsers.

Please find additional information at:
 - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/at
 - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/at#browser_compatibility
@Snuffleupagus Snuffleupagus linked an issue Jun 8, 2022 that may be closed by this pull request
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Jun 8, 2022

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8a99c862f9ce914/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 8, 2022

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/647a3c197f6793b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 8, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/8a99c862f9ce914/output.txt

Total script time: 3.15 mins

  • Unit Tests: FAILED

@pdfjsbot
Copy link

pdfjsbot commented Jun 8, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/647a3c197f6793b/output.txt

Total script time: 6.79 mins

  • Unit Tests: Passed

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError key.split("+")
3 participants