-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the unicorn/prefer-dom-node-append
ESLint plugin rule
#15029
Enable the unicorn/prefer-dom-node-append
ESLint plugin rule
#15029
Conversation
This rule will help enforce slightly shorter code, especially since you can insert multiple elements at once, and according to MDN `Element.append()` is available in all browsers that we currently support. Please find additional information here: - https://developer.mozilla.org/en-US/docs/Web/API/Element/append - https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-dom-node-append.md
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/83f7ccaf30fed0d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a32d95e6c36c218/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/83f7ccaf30fed0d/output.txt Total script time: 20.96 mins
Image differences available at: http://54.241.84.105:8877/83f7ccaf30fed0d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/a32d95e6c36c218/output.txt Total script time: 27.95 mins
|
/botio-linux browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ceddec429bf8079/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ceddec429bf8079/output.txt Total script time: 22.21 mins
Image differences available at: http://54.241.84.105:8877/ceddec429bf8079/reftest-analyzer.html#web=eq.log |
This mostly mechanical change reduces the size of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
This rule will help enforce slightly shorter code, especially since you can insert multiple elements at once, and according to MDN
Element.append()
is available in all browsers that we currently support.Please find additional information here: