Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend getGlyphMapForStandardFonts with some Hebrew entries (issue 15033) #15034

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Extend getGlyphMapForStandardFonts with some Hebrew entries (issue 15033) #15034

merged 1 commit into from
Jun 13, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Jun 13, 2022 •
edited
Loading

This only adds the minimum entries required in order to render the referenced document correctly, rather than trying to support "all" Hebrew glyphs, to ensure that all lines in getGlyphMapForStandardFonts are covered by tests.

@Snuffleupagus Snuffleupagus linked an issue Jun 13, 2022 that may be closed by this pull request
non-embedded font using identity encoding error leads to hebrew text not displayed correctly #15033
Closed
@Snuffleupagus
Extend getGlyphMapForStandardFonts with some Hebrew entries (issue …
2dca140 
…15033)

This only adds the minimum entries required in order to render the referenced document correctly, rather than trying to support "all" Hebrew glyphs, to ensure that all lines in `getGlyphMapForStandardFonts` are covered by tests.
@Snuffleupagus Snuffleupagus changed the title Extend getNonStdFontMap with some Hebrew entries (issue 15033) Extend getGlyphMapForStandardFonts with some Hebrew entries (issue 15033) Jun 13, 2022
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5afc80f6d86b97a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/25e92f269db7ad0/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/5afc80f6d86b97a/output.txt

Total script time: 26.08 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 25
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/5afc80f6d86b97a/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/25e92f269db7ad0/output.txt

Total script time: 28.54 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/25e92f269db7ad0/reftest-analyzer.html#web=eq.log

calixteman
calixteman reviewed Jun 13, 2022
View reviewed changes
src/core/standard_fonts.js
@@ -524,6 +524,33 @@ const getGlyphMapForStandardFonts = getLookupTableFactory(function (t) {
t[337] = 9552;
t[493] = 1039;
t[494] = 1040;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this patch, but could we fill the gaps ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, I'm not all that keen on adding a bunch of entries here without real-world test-cases that benefit from the changes.
Also, I believe that the list was (originally) purposely made sparse to keep its size down such that we don't unnecessarily bloat the file size here.

calixteman
calixteman approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Snuffleupagus Snuffleupagus merged commit 89cebcb into mozilla:master Jun 13, 2022
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c5c79005681101d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/8ebda40eb26e873/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/c5c79005681101d/output.txt

Total script time: 22.73 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/8ebda40eb26e873/output.txt

Total script time: 22.02 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-15033 branch June 13, 2022 10:02
@calixteman calixteman mentioned this pull request Jan 30, 2023
Merged
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
@earthywh earthywh mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
font-conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

non-embedded font using identity encoding error leads to hebrew text not displayed correctly
3 participants
@Snuffleupagus @pdfjsbot @calixteman