Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always flush the current item with MarkedContent stuff when getting text (#15094) #15105

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman requested a review from Snuffleupagus June 25, 2022 14:41
@calixteman calixteman linked an issue Jun 25, 2022 that may be closed by this pull request
@@ -2275,6 +2277,24 @@ Caron Broadcasting, Inc., an Ohio corporation (“Lessee”).`)
await loadingTask.destroy();
});

it("gets text content with or without includeMarkedContent, and compare (issue 15094)", async function () {
const loadingTask = getDocument(buildGetDocumentParams("issue15094.pdf"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems, as far as I can tell, that this issue is also reproducible using page 568 from the pdf.pdf file that we already use in the test-suite.
So how about using that document/page here instead, to avoid adding a new test-file?

@calixteman
Copy link
Contributor Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7aeef2603ccb578/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/099eafb58bb2826/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/099eafb58bb2826/output.txt

Total script time: 3.28 mins

  • Unit Tests: FAILED

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/7aeef2603ccb578/output.txt

Total script time: 14.40 mins

  • Unit Tests: Passed

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/bdafdb1f4f5e6be/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e36237669d58f15/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/e36237669d58f15/output.txt

Total script time: 25.95 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 23

Image differences available at: http://54.241.84.105:8877/e36237669d58f15/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/bdafdb1f4f5e6be/output.txt

Total script time: 29.58 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find feature produces some wrong highlightments
3 participants