Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a visible page border in HCM (bug 1776914) #15111

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

calixteman
Copy link
Contributor

No description provided.

@MReschenberg
Copy link

😁 thank you!

Copy link

@ahmed82 ahmed82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -30,7 +31,8 @@
:root {
--pdfViewer-padding-bottom: 9px;
--page-margin: 9px auto 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested, but simply reading the surrounding the code:
Don't you need to change these values, to account for the fact that there's now a border added just below?
Comparing with the "normal" rules, should this be updated to e.g. the following now?

Suggested change
--page-margin: 9px auto 0;
--page-margin: 8px auto -1px;

@@ -30,7 +31,8 @@
:root {
--pdfViewer-padding-bottom: 9px;
--page-margin: 9px auto 0;
--page-border: none;
--page-border: 1px solid CanvasText;
--page-border-image: none;
--spreadHorizontalWrapped-margin-LR: 4.5px;
Copy link
Collaborator

@Snuffleupagus Snuffleupagus Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested, but simply reading the surrounding the code:
Don't you need to change this value, to account for the fact that there's now a border added just above?
Comparing with the "normal" rules, should this be updated to e.g. the following now?

Suggested change
--spreadHorizontalWrapped-margin-LR: 4.5px;
--spreadHorizontalWrapped-margin-LR: 3.5px;

@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a8c89da62ac5f5d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/a8c89da62ac5f5d/output.txt

Total script time: 2.67 mins

Published

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants