[Editor] Change the cursor to a pen for the Ink editor #15146
Conversation
src/display/editor/ink.js
Outdated
| this.canvas.style.cursor = | ||
| "url(images/toolbarButton-editorInk.svg) 0 16, pointer"; |
There was a problem hiding this comment.
Can't you set this in the CSS file instead, rather than hard-coding it here?
calixteman
force-pushed
the
editing_cursor
branch
from
0e50a02
to
f2b481b
Compare
| @@ -132,6 +133,7 @@ | |||
|
|
|||
| .annotationEditorLayer .inkEditor.editing { | |||
| resize: none; | |||
| cursor: url(images/toolbarButton-editorInk.svg) 0 16, pointer; | |||
There was a problem hiding this comment.
Also, to improve maintainability (similar to other CSS files):
| cursor: url(images/toolbarButton-editorInk.svg) 0 16, pointer; | |
| cursor: var(--editorInk-editing-cursor) 0 16, pointer; |
... and add the following to the :root-declaration at the top of this file:
--editorInk-editing-cursor: url(images/toolbarButton-editorInk.svg);There was a problem hiding this comment.
I added the 0 16 in the var since those values are related to the image itself.
calixteman
force-pushed
the
editing_cursor
branch
from
f2b481b
to
edc9ad1
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2ae668d511be559/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6ae6e6761a3f9ed/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2ae668d511be559/output.txt Total script time: 4.73 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6ae6e6761a3f9ed/output.txt Total script time: 7.92 mins
|
No description provided.