[Editor] Unselect correctly removed editors #15210
Conversation
test/integration/test_utils.js
Outdated
| exports.editorPrefix = editorPrefix; | ||
|
|
||
| function getSelectedEditors(page) { | ||
| return page.evaluate(pref => { |
There was a problem hiding this comment.
Nit: Can this helper function perhaps use the same parameter name as before it was moved to this file, since I find "prefix" a slightly clearer name overall (since "pref" could generally be short for e.g. preference as well)?
| return page.evaluate(pref => { | |
| return page.evaluate(prefix => { |
test/integration/test_utils.js
Outdated
| for (const element of elements) { | ||
| results.push(parseInt(element.id.slice(pref.length))); |
There was a problem hiding this comment.
Nit: This could maybe be shortened a tiny bit?
| for (const element of elements) { | |
| results.push(parseInt(element.id.slice(pref.length))); | |
| for (const { id } of elements) { | |
| results.push(parseInt(id.slice(pref.length))); |
- After undoing a deletion of several editors, they appeared to be selected (they had a red border) when in fact they were not, consequently, this patch aims to remove the selectedEditor class when an editor is removed; - Add a test with some ink editors.
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0b79c0d295b1e1a/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/feec9d972aebf9e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/feec9d972aebf9e/output.txt Total script time: 4.82 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0b79c0d295b1e1a/output.txt Total script time: 7.52 mins
|
when in fact they were not, consequently, this patch aims to remove the selectedEditor class when
an editor is removed;