-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignoring "resize" events during printing (issue 15324) #15325
Conversation
Although it just occurred to me that this isn't really a good idea as-is, since the user can still manually re-size the browser window during printing and those events we still want to handle... |
I logged media changes (similarly to what is done in the test case in https://bugzilla.mozilla.org/show_bug.cgi?id=774398#c0) and window resize events, one resize is triggered between "before printing" and "after printing", so maybe this one could be ignored. |
This is a quick work-around, to prevent the viewer from breaking as a result of https://bugzilla.mozilla.org/show_bug.cgi?id=774398
b678406
to
f669e5d
Compare
It seems like this worked, thank you! |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/641ce7637bc7169/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/641ce7637bc7169/output.txt Total script time: 2.69 mins Published |
I'll try it with local build. |
WFM with a local build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
This is a quick work-around, to prevent the viewer from breaking as a result of https://bugzilla.mozilla.org/show_bug.cgi?id=774398