Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some Array.prototype-usage with spread syntax #15498

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

We have a few, quite old, call-sites that use the Array.prototype-format and which can now be replaced with spread syntax instead.

We have a few, quite old, call-sites that use the `Array.prototype`-format and which can now be replaced with spread syntax instead.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/666b9d554ce1f39/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ce8aba28e548a5c/output.txt

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/666b9d554ce1f39/output.txt

Total script time: 26.72 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 3

Image differences available at: http://54.241.84.105:8877/666b9d554ce1f39/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/ce8aba28e548a5c/output.txt

Total script time: 29.29 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/ce8aba28e548a5c/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit 7404091 into mozilla:master Sep 23, 2022
@Snuffleupagus Snuffleupagus deleted the more-spread branch September 23, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants