Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused Util.apply3dTransform method #15547

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Oct 7, 2022

This method was originally added in PR #1157 (back in 2012), however its only call-site was then removed in PR #2423 (also in 2012). Hence this method has been completely unused for nearly a decade, and it should thus be safe to remove it.

This method was originally added in PR 1157 (back in 2012), however its only call-site was then removed in PR 2423 (also in 2012).
Hence this method has been completely unused for nearly a decade, and it should thus be safe to remove it.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Oct 7, 2022

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6096b7f11626023/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 7, 2022

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c3094e357194103/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 7, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/6096b7f11626023/output.txt

Total script time: 25.40 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 22

Image differences available at: http://54.241.84.105:8877/6096b7f11626023/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Oct 7, 2022

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/c3094e357194103/output.txt

Total script time: 30.22 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 19

Image differences available at: http://54.193.163.58:8877/c3094e357194103/reftest-analyzer.html#web=eq.log

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@calixteman
Copy link
Contributor

The "regressions" on the xfa are because of:
https://bugzilla.mozilla.org/show_bug.cgi?id=1582545
and are unrelated to this patch.

@Snuffleupagus Snuffleupagus merged commit 9931295 into mozilla:master Oct 7, 2022
@Snuffleupagus Snuffleupagus deleted the rm-Util-apply3dTransform branch October 7, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants