-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the unused Util.apply3dTransform
method
#15547
Remove the unused Util.apply3dTransform
method
#15547
Conversation
This method was originally added in PR 1157 (back in 2012), however its only call-site was then removed in PR 2423 (also in 2012). Hence this method has been completely unused for nearly a decade, and it should thus be safe to remove it.
18aea81
to
4b39b1c
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6096b7f11626023/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c3094e357194103/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6096b7f11626023/output.txt Total script time: 25.40 mins
Image differences available at: http://54.241.84.105:8877/6096b7f11626023/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/c3094e357194103/output.txt Total script time: 30.22 mins
Image differences available at: http://54.193.163.58:8877/c3094e357194103/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The "regressions" on the xfa are because of: |
This method was originally added in PR #1157 (back in 2012), however its only call-site was then removed in PR #2423 (also in 2012). Hence this method has been completely unused for nearly a decade, and it should thus be safe to remove it.