[api-minor] Initialize the unicode-category *lazily* on the Glyph-instance
#15665
Conversation
…nstance The purpose of this patch is twofold: - Initialize the unicode-category data *lazily* during text-extraction, since this is completely unused during general parsing/rendering. - Stop exposing this data in the API, since it's unused on the main-thread and it seems like it was *accidentally* included. Obviously these changes are API-observable, but hopefully no user is depending on this. Furthermore, it's trivial for a user to re-create this unicode-category data manually with a regular expression (from the exposed `unicode` property).
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fcd46c58a2cba11/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f832062df222d2c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/fcd46c58a2cba11/output.txt Total script time: 25.13 mins
Image differences available at: http://54.241.84.105:8877/fcd46c58a2cba11/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f832062df222d2c/output.txt Total script time: 30.62 mins
Image differences available at: http://54.193.163.58:8877/f832062df222d2c/reftest-analyzer.html#web=eq.log |
|
/cc @calixteman since looking at the history of this file you added these fields; were they indeed exposed accidentally? |
|
Yep I exposed them accidentally. |
The purpose of this patch is twofold:
Obviously these changes are API-observable, but hopefully no user is depending on this. Furthermore, it's trivial for a user to re-create this unicode-category data manually with a regular expression (from the exposed
unicodeproperty).