[api-minor] Let the cMapPacked parameter, in getDocument, default to true
#15981
Conversation
Snuffleupagus
force-pushed
the
cMapPacked-true
branch
from
1fe00fb
to
7da2cb4
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/351b10b8b2ef209/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/61922865bc74d9f/output.txt |
… to `true` The initial CMap support was added in PR 4259 using the "raw" Adobe files, however they were quickly deemed to be unnecessarily large. As a result PR 4470 introduced the more compact "binary" CMap format, with both of those PRs being included in the very same release (version `0.8.1334`) . Please note that we've thus never shipped anything *except* the "binary" CMap files with the PDF library, and furthermore note that we've not even once updated the CMap files since they were originally added almost nine years ago. Requiring users to remember that `cMapPacked = true` is necessary, in addition to setting the `cMapUrl` parameter, in order for CMap loading to work feels like a less than ideal API. Hence this patch, which suggests that we simply let `cMapPacked` default to `true` now.
Snuffleupagus
force-pushed
the
cMapPacked-true
branch
from
7da2cb4
to
c5d6391
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/61922865bc74d9f/output.txt Total script time: 25.86 mins
Image differences available at: http://54.241.84.105:8877/61922865bc74d9f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/351b10b8b2ef209/output.txt Total script time: 32.31 mins
Image differences available at: http://54.193.163.58:8877/351b10b8b2ef209/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4ade014aca9805c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4ade014aca9805c/output.txt Total script time: 1.25 mins Published |
|
Thank you for simplifying this! |
The initial CMap support was added in PR #4259 using the "raw" Adobe files, however they were quickly deemed to be unnecessarily large. As a result PR #4470 introduced the more compact "binary" CMap format, with both of those PRs being included in the very same release (version
0.8.1334) .Please note that we've thus never shipped anything except the "binary" CMap files with the PDF library, and furthermore note that we've not even once updated the CMap files since they were originally added almost nine years ago.
Requiring users to remember that
cMapPacked = trueis necessary, in addition to setting thecMapUrlparameter, in order for CMap loading to work feels like a less than ideal API.Hence this patch, which suggests that we simply let
cMapPackeddefault totruenow.