[CRX] Set minimum_chrome_version to 88 #16600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set minimum_chrome_version to 88 to not distribute an incompatible version of the extension to older Chrome versions. See mozilla#13669 (comment)
timvandermeij
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set minimum_chrome_version to 88 to not distribute an incompatible version of the extension to older Chrome versions.
Note: I'm aware that the current master branch specifies the minimum supported Chrome version in the code to 92+ (by #16499). However, I am not convinced yet of dropping Chrome 91 support given the surprisingly large number of reported Chrome 91 users, as seen in #13669 (comment). Because of this information, I'm submitting the commit that I already included in the latest published version of the Chrome extension (https://github.com/Rob--W/pdf.js/releases/tag/chrome-3.7.108).