Update the ESLint globals list (PR 17055 follow-up)
#17123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that we only use standard `import`/`export` statements now, after recent PRs, the "exports" global is unused. Instead we add "__non_webpack_import__" to the `globals` to avoid having to sprinkle disable statements throughout the code. Finally, the way that `globals` are defined has changed in ESLint and we should thus explicitly specify them as "readonly"; please find additional details at https://eslint.org/docs/latest/use/configure/language-options#specifying-globals
Snuffleupagus
force-pushed
the
eslint-globals
branch
from
46c7ade
to
93f24dd
Compare
|
/botio lint |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/301a6d95e064be0/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4fd1dac87973d33/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4fd1dac87973d33/output.txt Total script time: 1.25 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/301a6d95e064be0/output.txt Total script time: 8.12 mins
|
timvandermeij
approved these changes
Oct 15, 2023
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we only use standard
import/exportstatements now, after recent PRs, the "exports" global is unused.Instead we add "__non_webpack_import__" to the
globalsto avoid having to sprinkle disable statements throughout the code.Finally, the way that
globalsare defined has changed in ESLint and we should thus explicitly specify them as "readonly"; please find additional details at https://eslint.org/docs/latest/use/configure/language-options#specifying-globals