Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firefox] Restore opening of PDF attachments (issue 17353, bug 1867764) #17363

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[Firefox] Restore opening of PDF attachments (issue 17353, bug 1867764) #17363

merged 1 commit into from
Dec 1, 2023

Commits on Dec 1, 2023

  1. [Firefox] Restore opening of PDF attachments (issue 17353) 

    This unfortunately broke in PR 17060, since I had completely forgotten about https://bugzilla.mozilla.org/show_bug.cgi?id=1632644#c5 when writing that patch.
The easiest solution, while slightly unfortunate, seems to be to add a couple of non-standard hash parameters specifically for the PDF attachment use-case in the Firefox PDF Viewer. (Note that we cannot use "nameddest" here, since we also need to support the stringified destination-Array case.)
    @Snuffleupagus
    Snuffleupagus committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    4c92ec9 View commit details
    Browse the repository at this point in the history