Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Avoid to scroll when an editor is unselected #17688

Merged
merged 1 commit into from
Feb 20, 2024
Merged

[Editor] Avoid to scroll when an editor is unselected #17688

merged 1 commit into from
Feb 20, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

It fixes #17327 (comment) in Chrome.

Snuffleupagus
Snuffleupagus approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last time that we fixed one of these Chrome-only editor issues there where some regressions (affecting all browsers), hopefully that doesn't happen this time.

r=me, with passing tests; thanks!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f70bbd09d42e397/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7aa0a329a3e8fde/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/f70bbd09d42e397/output.txt

Total script time: 5.95 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/7aa0a329a3e8fde/output.txt

Total script time: 17.05 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 70015ff into mozilla:master Feb 20, 2024
9 checks passed
@calixteman calixteman deleted the editor_no_scroll_unselect branch February 20, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus