Fallback on DeviceGray when a colorspace cannot be parsed #18468
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e199a0884cccef3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b429ead61c9fd25/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e199a0884cccef3/output.txt Total script time: 30.03 mins
Image differences available at: http://54.241.84.105:8877/e199a0884cccef3/reftest-analyzer.html#web=eq.log |
|
No regression, probably because most of the time colorspaces are valid. |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b429ead61c9fd25/output.txt Total script time: 44.49 mins
Image differences available at: http://54.193.163.58:8877/b429ead61c9fd25/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Looks good to me, with the comment from @Snuffleupagus addressed which I agree with, given that the specification indicates that DeviceGray should be the default (see #18466 (comment)), the reference tests don't show any regressions and issue6707-page1 is even improved. Thank you for doing this!
calixteman
force-pushed
the
dont_throw_with_invalid_cs
branch
from
ac9ae3d
to
71bae38
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5bb744c1d4f1641/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/64bf526f11d5d80/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5bb744c1d4f1641/output.txt Total script time: 29.94 mins
Image differences available at: http://54.241.84.105:8877/5bb744c1d4f1641/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/64bf526f11d5d80/output.txt Total script time: 44.62 mins
Image differences available at: http://54.193.163.58:8877/64bf526f11d5d80/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b96247cf8b2000b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c20a0ab9c983530/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b96247cf8b2000b/output.txt Total script time: 20.36 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/c20a0ab9c983530/output.txt Total script time: 24.90 mins
|
No description provided.