Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently dispatch events, if needed, when setting AppOptions #18495

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Consistently dispatch events, if needed, when setting AppOptions #18495

merged 1 commit into from
Jul 27, 2024

Commits on Jul 27, 2024

  1. Consistently dispatch events, if needed, when setting AppOptions 

    Currently we'll only dispatch events, for the options that support it, when updating preferences. Since this could potentially lead to inconsistent behaviour, let's avoid any future surprises by *always* dispatching events regardless of how the relevant option is being changed.

Obviously we should then also dispatch events in `AppOptions.set`, and to avoid adding even more duplicated code this method is changed into a wrapper for `AppOptions.setAll`.
While this is technically a tiny bit less efficient I don't think it matters in practice, since outside of development- and debug-mode `AppOptions.set` is barely used.
    @Snuffleupagus
    Snuffleupagus committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    58c7b5b View commit details
    Browse the repository at this point in the history