Change the BaseCMapReaderFactory fetch-helper to return a Uint8Array
#18933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves more functionality into the base-class, rather than having to duplicate that in the extending classes. For consistency, also updates the `BaseStandardFontDataFactory` and introduces more `async`/`await` in various relevant code.
We can re-use the existing helpers from `src/display/` rather than re-implementing the functionality here.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/037a107f75fb9a8/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b67dfb02b4ffa70/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b67dfb02b4ffa70/output.txt Total script time: 32.55 mins
Image differences available at: http://54.241.84.105:8877/b67dfb02b4ffa70/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/037a107f75fb9a8/output.txt Total script time: 51.77 mins
Image differences available at: http://54.193.163.58:8877/037a107f75fb9a8/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Oct 22, 2024
|
Nice improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
BaseCMapReaderFactoryfetch-helper to return aUint8ArrayThis moves more functionality into the base-class, rather than having to duplicate that in the extending classes.
For consistency, also updates the
BaseStandardFontDataFactoryand introduces moreasync/awaitin various relevant code.Re-factor the
DefaultFileReaderFactoryunit-test helperWe can re-use the existing helpers from
src/display/rather than re-implementing the functionality here.